linux-kernel - Re: [PATCH] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9k_kaGiLi069EcE0WduKtA6pF_vM3PAE5-nzhLDUinjQQ@mail.gmail.com>
Date: Mon, 14 Apr 2025 09:32:59 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <kees@...nel.org>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

On Mon, Apr 14, 2025 at 5:02 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> On Mon, 14 Apr 2025 at 10:50, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > Enabling a (modular) test should not silently enable additional kernel
> > functionality, as that may increase the attack vector of a product.
> >
> > Fix this by making PRIME_NUMBERS_KUNIT_TEST depend on PRIME_NUMBERS
> > instead of selecting it.
> >
> > After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to build
> > modules for all appropriate tests for ones system, without pulling in
> > extra unwanted functionality, while still allowing a tester to manually
> > enable PRIME_NUMBERS and this test suite on a system where PRIME_NUMBERS
> > is not enabled by default.
> >
> > Fixes: 313b38a6ecb46db4 ("lib/prime_numbers: convert self-test to KUnit")
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Tamir Duberstein <tamird@...il.com>