linux-kernel - Re: [PATCH net-next v5 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e394736-00c6-4671-a55e-6019ce245b01@lunn.ch>
Date: Mon, 14 Apr 2025 15:34:01 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, nm@...com, ssantosh@...nel.org,
	tony@...mide.com, richardcochran@...il.com, glaroque@...libre.com,
	schnelle@...ux.ibm.com, m-karicheri2@...com, s.hauer@...gutronix.de,
	rdunlap@...radead.org, diogo.ivo@...mens.com, basharath@...thit.com,
	horms@...nel.org, jacob.e.keller@...el.com, m-malladi@...com,
	javier.carrasco.cruz@...il.com, afd@...com, s-anna@...com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	pratheesh@...com, prajith@...com, vigneshr@...com, praneeth@...com,
	srk@...com, rogerq@...com, krishna@...thit.com, pmohan@...thit.com,
	mohan@...thit.com
Subject: Re: [PATCH net-next v5 05/11] net: ti: prueth: Adds ethtool support
 for ICSSM PRUETH Driver

> +static int icssm_emac_get_link_ksettings(struct net_device *ndev,
> +					 struct ethtool_link_ksettings *ecmd)
> +{
> +	return phy_ethtool_get_link_ksettings(ndev, ecmd);
> +}
> +

> +static int
> +icssm_emac_set_link_ksettings(struct net_device *ndev,
> +			      const struct ethtool_link_ksettings *ecmd)
> +{
> +	return phy_ethtool_set_link_ksettings(ndev, ecmd);
> +}

> +/* Ethtool support for EMAC adapter */
> +const struct ethtool_ops emac_ethtool_ops = {
> +	.get_drvinfo = icssm_emac_get_drvinfo,
> +	.get_link_ksettings = icssm_emac_get_link_ksettings,
> +	.set_link_ksettings = icssm_emac_set_link_ksettings,

The wrappers don't do anything, so why not just use
phy_ethtool_get_link_ksettings() and phy_ethtool_set_link_ksettings()
directly?

	Andrew