linux-kernel - Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1tt6qhmc2.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 14 Apr 2025 10:03:54 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        Ard
 Biesheuvel <ardb@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, loongarch@...ts.linux.dev,
        linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        sparclinux@...r.kernel.org, linux-s390@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init


Eric,

> All of the CRC library's CPU feature static_keys are initialized by
> initcalls and never change afterwards, so there's no need for them to
> be in the regular .data section. Put them in .data..ro_after_init
> instead.

LGTM.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen