linux-kernel - Re: [patch 4/7] ARM: orion/gpio:: Convert generic irqchip locking to guard()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mscihl4b.fsf@BLaptop.bootlin.com>
Date: Mon, 14 Apr 2025 16:29:40 +0200
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Uwe Kleine-König
 <ukleinek@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Bartosz
 Golaszewski <brgl@...ev.pl>, Talel Shenhar <talel@...zon.com>, Nicolas
 Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Guo Ren <guoren@...nel.org>, Herve Codina
 <herve.codina@...tlin.com>, Huacai Chen <chenhuacai@...nel.org>, Jiaxun
 Yang <jiaxun.yang@...goat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Chen-Yu Tsai <wens@...e.org>, Jernej
 Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>
Subject: Re: [patch 4/7] ARM: orion/gpio:: Convert generic irqchip locking
 to guard()

Hello Thomas,

> Conversion was done with Coccinelle. No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Gregory Clement <gregory.clement@...tlin.com>

Applied on mvebu/arm

Thanks,

Gregory


> ---
>  arch/arm/plat-orion/gpio.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/arch/arm/plat-orion/gpio.c
> +++ b/arch/arm/plat-orion/gpio.c
> @@ -496,11 +496,10 @@ static void orion_gpio_unmask_irq(struct
>  	u32 reg_val;
>  	u32 mask = d->mask;
>  
> -	irq_gc_lock(gc);
> +	guard(raw_spinlock)(&gc->lock);
>  	reg_val = irq_reg_readl(gc, ct->regs.mask);
>  	reg_val |= mask;
>  	irq_reg_writel(gc, reg_val, ct->regs.mask);
> -	irq_gc_unlock(gc);
>  }
>  
>  static void orion_gpio_mask_irq(struct irq_data *d)
> @@ -510,11 +509,10 @@ static void orion_gpio_mask_irq(struct i
>  	u32 mask = d->mask;
>  	u32 reg_val;
>  
> -	irq_gc_lock(gc);
> +	guard(raw_spinlock)(&gc->lock);
>  	reg_val = irq_reg_readl(gc, ct->regs.mask);
>  	reg_val &= ~mask;
>  	irq_reg_writel(gc, reg_val, ct->regs.mask);
> -	irq_gc_unlock(gc);
>  }
>  
>  void __init orion_gpio_init(int gpio_base, int ngpio,
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com