linux-kernel - Re: [PATCH] arm[64]/memremap: fix arch_memremap_can_ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f7a84af-444f-46a9-b518-4fb010b7fba0@gmail.com>
Date: Mon, 14 Apr 2025 09:18:28 -0500
From: Ross Stutterheim <ross.sweng@...il.com>
To: Catalin Marinas <catalin.marinas@....com>,
 Ross Stutterheim <ross.stutterheim@...min.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Mike Rapoport <rppt@...nel.org>, Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH] arm[64]/memremap: fix arch_memremap_can_ram_remap()

On 4/14/25 08:49, Catalin Marinas wrote:
> Please cc the maintainers and the original contributor of the commit you
> are fixing, otherwise the patch may not be noticed.
Thanks for adding them on your reply. I will add to V2.

>> diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
>> index 10e246f11271..48c38c986b95 100644
>> --- a/arch/arm64/mm/ioremap.c
>> +++ b/arch/arm64/mm/ioremap.c
>> @@ -51,7 +51,5 @@ void __init early_ioremap_init(void)
>>   bool arch_memremap_can_ram_remap(resource_size_t offset, size_t size,
>>   				 unsigned long flags)
>>   {
>> -	unsigned long pfn = PHYS_PFN(offset);
>> -
>> -	return pfn_is_map_memory(pfn);
>> +	return pfn_is_map_memory(offset);
> 
> This is already correct.
Will remove on V2.

--
Ross