linux-kernel - Re: [PATCH] tpm_crb: ffa_tpm: return errors from interface functions if no ffa-crb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250414-tiny-swan-of-tempest-ddcbdd@sudeepholla>
Date: Mon, 14 Apr 2025 16:18:07 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Stuart Yoder <stuart.yoder@....com>
Cc: <linux-integrity@...r.kernel.org>, <jarkko@...nel.org>,
	Sudeep Holla <sudeep.holla@....com>, <peterhuewe@....de>,
	<jgg@...pe.ca>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm_crb: ffa_tpm: return errors from interface functions
 if no ffa-crb driver

On Mon, Apr 14, 2025 at 09:52:35AM -0500, Stuart Yoder wrote:
> If ACPI advertises an FF-A based TPM but the tpm_crb_ffa driver is not
> enabled via Kconfig, inline stub versions of the interface functions
> are used. These functions incorrectly return 0, which indicates success.
> The result is that the tpm_crb probe function continues execution and
> eventually detects a timeout at the TPM.
> 
> Change the inline functions to return errors, so that probe() sees that
> tpm_crb_ffa is not present and aborts the probe.
> 

LGTM,

Acked-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep