linux-kernel - RE: [Intel-wired-lan] [PATCH net-next 7/7] net/mlx5: Don't use %pK through tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB586686DC91E86402285CB8ABE5B32@SJ0PR11MB5866.namprd11.prod.outlook.com>
Date: Mon, 14 Apr 2025 16:17:49 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
	Jeff Johnson <jjohnson@...nel.org>, Loic Poulain <loic.poulain@...aro.org>,
	Brian Norris <briannorris@...omium.org>, Francesco Dolcini
	<francesco@...cini.it>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Dumazet,
 Eric" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
	<leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>
CC: "ath10k@...ts.infradead.org" <ath10k@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ath11k@...ts.infradead.org" <ath11k@...ts.infradead.org>,
	"ath12k@...ts.infradead.org" <ath12k@...ts.infradead.org>,
	"wcn36xx@...ts.infradead.org" <wcn36xx@...ts.infradead.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next 7/7] net/mlx5: Don't use %pK
 through tracepoints



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Thomas Weißschuh
> Sent: Monday, April 14, 2025 10:26 AM
> To: Jeff Johnson <jjohnson@...nel.org>; Loic Poulain
> <loic.poulain@...aro.org>; Brian Norris <briannorris@...omium.org>;
> Francesco Dolcini <francesco@...cini.it>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> David S. Miller <davem@...emloft.net>; Dumazet, Eric
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Saeed Mahameed <saeedm@...dia.com>; Leon
> Romanovsky <leon@...nel.org>; Tariq Toukan <tariqt@...dia.com>
> Cc: ath10k@...ts.infradead.org; linux-kernel@...r.kernel.org;
> ath11k@...ts.infradead.org; ath12k@...ts.infradead.org;
> wcn36xx@...ts.infradead.org; linux-wireless@...r.kernel.org; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-rdma@...r.kernel.org;
> Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> Subject: [Intel-wired-lan] [PATCH net-next 7/7] net/mlx5: Don't use %pK
> through tracepoints
> 
> In the past %pK was preferable to %p as it would not leak raw pointer values
> into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the
> regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through tracepoints. They can still unintentionally leak raw pointers or acquire
> sleeping looks in atomic contexts.
> 
> Switch to the regular pointer formatting which is safer and easier to reason
> about.
> There are still a few users of %pK left, but these use it through seq_file, for
> which its usage is safe.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h
> b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h
> index
> 0537de86f9817dc80bd897688c539135b1ad37ac..9b0f44253f332aa602a8
> 4a1f6d7532a500dd4f55 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint
> +++ .h
> @@ -28,7 +28,7 @@ DECLARE_EVENT_CLASS(mlx5_sf_dev_template,
>  				   __entry->hw_fn_id = sfdev->fn_id;
>  				   __entry->sfnum = sfdev->sfnum;
>  		    ),
> -		    TP_printk("(%s) sfdev=%pK aux_id=%d hw_id=0x%x
> sfnum=%u\n",
> +		    TP_printk("(%s) sfdev=%p aux_id=%d hw_id=0x%x
> sfnum=%u\n",
>  			      __get_str(devname), __entry->sfdev,
>  			      __entry->aux_id, __entry->hw_fn_id,
>  			      __entry->sfnum)
> 
> --
> 2.49.0