linux-kernel - Re: [PATCH] Added usb_string function to a namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ecxuaean.fsf@trenco.lwn.net>
Date: Mon, 14 Apr 2025 10:38:56 -0600
From: Jonathan Corbet <corbet@....net>
To: Kevin Paul Reddy Janagari <kevinpaul468@...il.com>,
 rdunlap@...radead.org, rbrasga@....edu, kevinpaul468@...il.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: skhan@...uxfoundation.org
Subject: Re: [PATCH] Added usb_string function to a namespace

Kevin Paul Reddy Janagari <kevinpaul468@...il.com> writes:

> with reference to WARNING:
> Duplicate C declaration, also defined at driver-api/usb/gadget:804
> There is a function usb_string in the file message.c,
> there is also a struct usb_string in the kernel api headers.
> The docs is unable to index the function as the index is occupied by struct
> This fix adds messgae.c to the usb_core namespace (in docs) hence providing
> usb_sting a unique index usb_core.usb_string()
>
> Signed-off-by: Kevin Paul Reddy Janagari <kevinpaul468@...il.com>
> ---
>  Documentation/driver-api/usb/usb.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/driver-api/usb/usb.rst b/Documentation/driver-api/usb/usb.rst
> index 89f9c37bb979..976fb4221062 100644
> --- a/Documentation/driver-api/usb/usb.rst
> +++ b/Documentation/driver-api/usb/usb.rst
> @@ -161,6 +161,7 @@ rely on 64bit DMA to eliminate another kind of bounce buffer.
>  .. kernel-doc:: drivers/usb/core/urb.c
>     :export:
>  
> +.. c:namespace:: usb_core
>  .. kernel-doc:: drivers/usb/core/message.c
>     :export:

I hate this sort of workaround ... but so be it.  Someday maybe it won't
be needed...

Applied, thanks,

jon