linux-kernel - Re: [PATCH] crypto: ccp: Fix __sev_snp_shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edc4c309-6936-c7b5-9050-106220fb3fcb@amd.com>
Date: Mon, 14 Apr 2025 12:04:56 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Ashish Kalra <Ashish.Kalra@....com>, dan.carpenter@...aro.org,
 john.allen@....com, herbert@...dor.apana.org.au, davem@...emloft.net
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked()

On 4/9/25 14:34, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@....com>
> 
> Fix smatch warning:
> 	drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked()
> 	error: uninitialized symbol 'dfflush_error'.
> 
> Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/linux-crypto/d9c2e79c-e26e-47b7-8243-ff6e7b101ec3@stanley.mountain/
> Signed-off-by: Ashish Kalra <ashish.kalra@....com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
>  drivers/crypto/ccp/sev-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 19fb51558a7d..1ccff5e3f4bc 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic)
>  	ret = __sev_do_cmd_locked(SEV_CMD_SNP_SHUTDOWN_EX, &data, error);
>  	/* SHUTDOWN may require DF_FLUSH */
>  	if (*error == SEV_RET_DFFLUSH_REQUIRED) {
> -		int dfflush_error;
> +		int dfflush_error = SEV_RET_NO_FW_CALL;
>  
>  		ret = __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &dfflush_error);
>  		if (ret) {