linux-kernel - Re: [PATCH kernfs 1/3] kernfs: switch global kernfs_idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_1BSLbvq4zCYEu-@slm.duckdns.org>
Date: Mon, 14 Apr 2025 07:09:28 -1000
From: Tejun Heo <tj@...nel.org>
To: alexjlzheng@...il.com
Cc: gregkh@...uxfoundation.org, alexjlzheng@...cent.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH kernfs 1/3] kernfs: switch global kernfs_idr_lock to
 per-fs lock

On Sat, Apr 12, 2025 at 02:31:07AM +0800, alexjlzheng@...il.com wrote:
> From: Jinliang Zheng <alexjlzheng@...cent.com>
> 
> The kernfs implementation has big lock granularity(kernfs_idr_lock) so
> every kernfs-based(e.g., sysfs, cgroup) fs are able to compete the lock.
> 
> This patch switches the global kernfs_idr_lock to per-fs lock, which
> put the spinlock into kernfs_root.
> 
> Signed-off-by: Jinliang Zheng <alexjlzheng@...cent.com>

Given that it doesn't really make things any more complicated, I think this
makes more sense than the existing code even without any direct evidence
that this improves performance.

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun