linux-kernel - Re: [PATCH v4 2/2] thermal: thermal-generic-adc: add temperature sensor channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250414193538.5eb8e4a4@jic23-huawei>
Date: Mon, 14 Apr 2025 19:35:38 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano
 <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba
 <lukasz.luba@....com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Laxman Dewangan
 <ldewangan@...dia.com>, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH v4 2/2] thermal: thermal-generic-adc: add temperature
 sensor channel

> > > > > > +
> > > > > > +       indio_dev->name = dev_name(dev);  
> > > >
> > > > What does this end up as?  The convention in IIO is to name after
> > > > a part number.  If you have duplicates this isn't how you tell them
> > > > apart.  So I'd kind of expect thermal-generic-temp or
> > > > something like that.
> > > >  
> > >
> > > it is "generic-adc-thermal" with this name, it is not present anywhere in IIO.
> > >  
> 
> Then this is acceptable?

That string is fine.  I'd still be tempted to hard code it here so the
value is obvious to anyone looking at the driver.

Thanks,

Jonathan