linux-kernel - Re: [PATCH net v5] batman-adv: Fix double-hold of meshif when getting enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJEFq4QeFDSq=-7NdPnqPgwMJDd5xvQ70YUEqHjNjdchw@mail.gmail.com>
Date: Mon, 14 Apr 2025 11:41:56 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Sven Eckelmann <sven@...fation.org>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, b.a.t.m.a.n@...ts.open-mesh.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	syzbot+ff3aa851d46ab82953a3@...kaller.appspotmail.com, 
	syzbot+4036165fc595a74b09b2@...kaller.appspotmail.com, 
	syzbot+c35d73ce910d86c0026e@...kaller.appspotmail.com, 
	syzbot+48c14f61594bdfadb086@...kaller.appspotmail.com, 
	syzbot+f37372d86207b3bb2941@...kaller.appspotmail.com
Subject: Re: [PATCH net v5] batman-adv: Fix double-hold of meshif when getting enabled

On Mon, Apr 14, 2025 at 11:05 AM Sven Eckelmann <sven@...fation.org> wrote:
>
> It was originally meant to replace the dev_hold with netdev_hold. But this
> was missed in batadv_hardif_enable_interface(). As result, there was an
> imbalance and a hang when trying to remove the mesh-interface with
> (previously) active hard-interfaces:
>
>   unregister_netdevice: waiting for batadv0 to become free. Usage count = 3
>
> Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot+ff3aa851d46ab82953a3@...kaller.appspotmail.com
> Reported-by: syzbot+4036165fc595a74b09b2@...kaller.appspotmail.com
> Reported-by: syzbot+c35d73ce910d86c0026e@...kaller.appspotmail.com
> Reported-by: syzbot+48c14f61594bdfadb086@...kaller.appspotmail.com
> Reported-by: syzbot+f37372d86207b3bb2941@...kaller.appspotmail.com
> Signed-off-by: Sven Eckelmann <sven@...fation.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>