linux-kernel - RE: [PATCH v3] hv/hv_kvp_daemon: Enable debug logs for hv_kvp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL4PR21MB46271A66420D9B03C2947360BFB32@BL4PR21MB4627.namprd21.prod.outlook.com>
Date: Mon, 14 Apr 2025 20:57:07 +0000
From: Dexuan Cui <decui@...rosoft.com>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>, KY Srinivasan
	<kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
	<wei.liu@...nel.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Shradha Gupta <shradhagupta@...rosoft.com>
Subject: RE: [PATCH v3] hv/hv_kvp_daemon: Enable debug logs for hv_kvp_daemon

> From: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> Sent: Sunday, April 6, 2025 1:48 AM
> [...]
> @@ -1662,6 +1708,7 @@ void print_usage(char *argv[])
>  	fprintf(stderr, "Usage: %s [options]\n"
>  		"Options are:\n"
>  		"  -n, --no-daemon        stay in foreground, don't
> daemonize\n"
> +		"  -d, --debug-enabled    Enable debug logs(syslog debug by

Maybe we can shorten --debug-enabled to --debug ? Just wanted to type
less characters :-) 
IMO conventionally --debug already means "debugging is enabled".

> @@ -1681,12 +1728,13 @@ int main(int argc, char *argv[])
>  	static struct option long_options[] = {
> [...]
> +		{"debug-enabled",	no_argument,	   0,  'd' },

Ditto.

Otherwise, LGTM.

Reviewed-by: Dexuan Cui <decui@...rosoft.com>