linux-kernel - Re: [PATCH] dt-bindings: PCI: Convert marvell,armada8k-pcie to schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174466977142.1877467.9140482106900041765.robh@kernel.org>
Date: Mon, 14 Apr 2025 17:29:31 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
 Jingoo Han <jingoohan1@...il.com>, linux-kernel@...r.kernel.org, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, 
 Gustavo Pimentel <gustavo.pimentel@...opsys.com>, 
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 linux-arm-kernel@...ts.infradead.org, Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Wilczyński <kw@...ux.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: Convert marvell,armada8k-pcie to
 schema


On Mon, 14 Apr 2025 16:41:33 -0500, Rob Herring (Arm) wrote:
> Convert the marvell,armada8k-pcie binding to DT schema. The binding
> uses different names for reg, clocks, and phys which have to be added
> to the common Synopsys DWC binding.
> 
> The "marvell,reset-gpio" property was not documented. Mark it deprecated
> as the "reset-gpios" property can be used instead. The "msi-parent"
> property was also not documented.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../bindings/pci/marvell,armada8k-pcie.yaml   | 100 ++++++++++++++++++
>  .../devicetree/bindings/pci/pci-armada8k.txt  |  48 ---------
>  .../bindings/pci/snps,dw-pcie-common.yaml     |   3 +-
>  .../devicetree/bindings/pci/snps,dw-pcie.yaml |   4 +-
>  MAINTAINERS                                   |   2 +-
>  5 files changed, 106 insertions(+), 51 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.yaml
>  delete mode 100644 Documentation/devicetree/bindings/pci/pci-armada8k.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.example.dtb: pcie@...00000 (marvell,armada8k-pcie): interrupts: [[0], [32], [4]] is too long
	from schema $id: http://devicetree.org/schemas/pci/marvell,armada8k-pcie.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250414214135.1680076-1-robh@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.