linux-kernel - Re: [PATCH] dmaengine: ptdma: Remove dead code from pt_dmaengine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y0w27427.fsf@AUSNATLYNCH.amd.com>
Date: Mon, 14 Apr 2025 17:48:16 -0500
From: Nathan Lynch <nathan.lynch@....com>
To: Eder Zulian <ezulian@...hat.com>
CC: <Basavaraj.Natikar@....com>, <vkoul@...nel.org>,
	<dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: ptdma: Remove dead code from
 pt_dmaengine_register()

Eder Zulian <ezulian@...hat.com> writes:
> devm_kasprintf() is used to allocate and format a string and the
> returned pointer is assigned to 'cmd_cache_name'. However, the variable
> 'cmd_cache_name' is not effectively used.
>
> Remove the dead code.
>
> Signed-off-by: Eder Zulian <ezulian@...hat.com>

While I work at AMD, I don't work on this driver and I defer to
Basavaraj. But it's easy to verify that cmd_cache_name is indeed
unused.

BTW it looks like struct pt_device->dma_cmd_cache could also be
discarded.

Reviewed-by: Nathan Lynch <nathan.lynch@....com>

> ---
>  drivers/dma/amd/ptdma/ptdma-dmaengine.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> index 715ac3ae067b..3a8014fb9cb4 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> @@ -565,7 +565,6 @@ int pt_dmaengine_register(struct pt_device *pt)
>  	struct ae4_device *ae4 = NULL;
>  	struct pt_dma_chan *chan;
>  	char *desc_cache_name;
> -	char *cmd_cache_name;
>  	int ret, i;
>  
>  	if (pt->ver == AE4_DMA_VERSION)
> @@ -581,12 +580,6 @@ int pt_dmaengine_register(struct pt_device *pt)
>  	if (!pt->pt_dma_chan)
>  		return -ENOMEM;
>  
> -	cmd_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
> -					"%s-dmaengine-cmd-cache",
> -					dev_name(pt->dev));
> -	if (!cmd_cache_name)
> -		return -ENOMEM;
> -
>  	desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
>  					 "%s-dmaengine-desc-cache",
>  					 dev_name(pt->dev));
> -- 
> 2.49.0