lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a2a743c8-3288-484d-935e-db0b2737b3de@intel.com>
Date: Mon, 14 Apr 2025 16:29:49 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Fenghua Yu <fenghuay@...dia.com>, James Morse <james.morse@....com>,
	<x86@...nel.org>, <linux-kernel@...r.kernel.org>
CC: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>, Babu Moger
	<Babu.Moger@....com>, <shameerali.kolothum.thodi@...wei.com>, "D Scott
 Phillips OS" <scott@...amperecomputing.com>, <carl@...amperecomputing.com>,
	<lcherian@...vell.com>, <bobo.shaobowang@...wei.com>,
	<tan.shaopeng@...itsu.com>, <baolin.wang@...ux.alibaba.com>, Jamie Iles
	<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>,
	<peternewman@...gle.com>, <dfustini@...libre.com>, <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
	"Dave Martin" <dave.martin@....com>, Koba Ko <kobak@...dia.com>, Shanker
 Donthineni <sdonthineni@...dia.com>
Subject: Re: [PATCH v8 17/21] x86,fs/resctrl: Move the resctrl filesystem code
 to live in /fs/resctrl

Hi Fenghua,

On 4/14/25 4:22 PM, Fenghua Yu wrote:
> Hi, Reinette,
> 
> On 4/14/25 09:04, Reinette Chatre wrote:
>> Hi Fenghua,
>>
>> On 4/11/25 5:18 PM, Fenghua Yu wrote:
>>
>>>>    arch/x86/kernel/cpu/resctrl/ctrlmondata.c     |  636 ---
>>>>    arch/x86/kernel/cpu/resctrl/internal.h        |  380 +-
>>>>    arch/x86/kernel/cpu/resctrl/monitor.c         |  902 +---
>>>>    arch/x86/kernel/cpu/resctrl/monitor_trace.h   |   18 +-
>>>>    arch/x86/kernel/cpu/resctrl/pseudo_lock.c     | 1080 +---
>>>>    .../kernel/cpu/resctrl/pseudo_lock_trace.h    |    2 +
>>>>    arch/x86/kernel/cpu/resctrl/rdtgroup.c        | 4556 +----------------
>>>>    fs/resctrl/ctrlmondata.c                      |  660 +++
>>>>    fs/resctrl/internal.h                         |  442 ++
>>>>    fs/resctrl/monitor.c                          |  932 ++++
>>>>    fs/resctrl/monitor_trace.h                    |   33 +
>>>>    fs/resctrl/pseudo_lock.c                      | 1115 ++++
>>>>    fs/resctrl/pseudo_lock_trace.h                |   17 +
>>>>    fs/resctrl/rdtgroup.c                         | 4313 ++++++++++++++++
>>>>    14 files changed, 7668 insertions(+), 7418 deletions(-)
>> This patch is huge. Placing a response in the middle of it makes your feedback
>> very hard to find. Please trim your replies.
>>
>> Reinette
>>
>>
> You are right! I re-sent my comment and remove all irrelevant code. Now hopefully it's easier to see my comment:)
> 

Thank you very much for re-sending the trimmed version. This helps a lot.

Reinette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ