linux-kernel - Re: [PATCH v4 5/5] clk: sophgo: Add clock controller support for SG2044 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5f59282-3551-4f2c-9c85-09a3ccec4745@kernel.org>
Date: Mon, 14 Apr 2025 08:42:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>,
 Richard Cochran <richardcochran@...il.com>,
 Alexander Sverdlin <alexander.sverdlin@...il.com>,
 Arnd Bergmann <arnd@...db.de>, Linus Walleij <linus.walleij@...aro.org>,
 Vinod Koul <vkoul@...nel.org>, Nikita Shubin <nikita.shubin@...uefel.me>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 sophgo@...ts.linux.dev, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, Yixun Lan <dlan@...too.org>,
 Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH v4 5/5] clk: sophgo: Add clock controller support for
 SG2044 SoC

On 14/04/2025 00:44, Inochi Amaoto wrote:
> +
> +static int sg2044_clk_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct sg2044_clk_ctrl *ctrl;
> +	const struct sg2044_clk_desc_data *desc;
> +	void __iomem *reg;
> +	u32 num_clks;
> +
> +	reg = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(reg))
> +		return PTR_ERR(reg);
> +
> +	desc = device_get_match_data(dev);
> +	if (!desc)
> +		return dev_err_probe(dev, -EINVAL, "no match data for platform\n");
> +
> +	num_clks = desc->num_div + desc->num_gate + desc->num_mux;
> +
> +	ctrl = devm_kzalloc(dev, struct_size(ctrl, data.hws, num_clks), GFP_KERNEL);
> +	if (!ctrl)
> +		return -ENOMEM;
> +
> +	ctrl->data.num = num_clks;
> +
> +	return sg2044_clk_init_ctrl(dev, reg, ctrl, desc);
> +}
> +
> +static struct sg2044_clk_desc_data sg2044_clk_desc_data = {

This must be const.

> +	.div = sg2044_div_commons,
> +	.mux = sg2044_mux_commons,
> +	.gate = sg2044_gate_commons,
> +	.num_div = ARRAY_SIZE(sg2044_div_commons),
> +	.num_mux = ARRAY_SIZE(sg2044_mux_commons),
> +	.num_gate = ARRAY_SIZE(sg2044_gate_commons),
> +};
> +
Best regards,
Krzysztof