linux-kernel - Re: [PATCH net] net: openvswitch: fix nested key length validation in the set() action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8141724C-7CC1-4715-B5DF-0469273E8358@redhat.com>
Date: Mon, 14 Apr 2025 09:03:06 +0200
From: Eelco Chaudron <echaudro@...hat.com>
To: Ilya Maximets <i.maximets@....org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 dev@...nvswitch.org, linux-kernel@...r.kernel.org,
 Aaron Conole <aconole@...hat.com>,
 syzbot+b07a9da40df1576b8048@...kaller.appspotmail.com
Subject: Re: [PATCH net] net: openvswitch: fix nested key length validation in
 the set() action

On 12 Apr 2025, at 12:40, Ilya Maximets wrote:

> It's not safe to access nla_len(ovs_key) if the data is smaller than
> the netlink header.  Check that the attribute is OK first.
>
> Fixes: ccb1352e76cf ("net: Add Open vSwitch kernel components.")
> Reported-by: syzbot+b07a9da40df1576b8048@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=b07a9da40df1576b8048
> Tested-by: syzbot+b07a9da40df1576b8048@...kaller.appspotmail.com
> Signed-off-by: Ilya Maximets <i.maximets@....org>

The patch looks good to me.

Reviewed-by:  Eelco Chaudron <echaudro@...hat.com>