linux-kernel - Re: [PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea1af202-6349-4f1f-ae15-41a483e99c2c@linaro.org>
Date: Mon, 14 Apr 2025 09:38:38 +0200
From: neil.armstrong@...aro.org
To: Andy Yan <andyshrk@....com>, lumag@...nel.org
Cc: cristian.ciocaltea@...labora.com, mripard@...nel.org,
 andrzej.hajda@...el.com, dianders@...omium.org, jernej.skrabec@...il.com,
 Laurent.pinchart@...asonboard.com, maarten.lankhorst@...ux.intel.com,
 rfoss@...nel.org, simona@...ll.ch, tzimmermann@...e.de,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 heiko@...ech.de, Andy Yan <andy.yan@...k-chips.com>
Subject: Re: [PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

On 11/04/2025 13:59, Andy Yan wrote:
> From: Andy Yan <andy.yan@...k-chips.com>
> 
> It is not recommended for drivers to include UAPI header
> directly.
> 
> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> 
> ---
> 
> Changes in v2:
> - Collect R-b from Heiko.
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index b1cdf806b3c40..deaba3b6f9978 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -22,8 +22,8 @@
>   
>   #include <media/cec-notifier.h>
>   
> -#include <uapi/linux/media-bus-format.h>
> -#include <uapi/linux/videodev2.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/videodev2.h>
>   
>   #include <drm/bridge/dw_hdmi.h>
>   #include <drm/display/drm_hdmi_helper.h>

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>