linux-kernel - RE: [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11492DDF2728C9D3B3F14DCA38AB32@TYCPR01MB11492.jpnprd01.prod.outlook.com>
Date: Mon, 14 Apr 2025 07:54:12 +0000
From: Thierry Bultel <thierry.bultel.yh@...renesas.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: "thierry.bultel@...atsea.fr" <thierry.bultel@...atsea.fr>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>, Paul Barker
	<paul.barker.ct@...renesas.com>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>
Subject: RE: [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: vendredi 11 avril 2025 16:57
> To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> Cc: thierry.bultel@...atsea.fr; linux-renesas-soc@...r.kernel.org;
> geert@...ux-m68k.org; Paul Barker <paul.barker.ct@...renesas.com>; Wolfram
> Sang <wsa+renesas@...g-engineering.com>; linux-kernel@...r.kernel.org;
> linux-serial@...r.kernel.org
> Subject: Re: [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI
> 
> On Thu, Apr 03, 2025 at 11:29:12PM +0200, Thierry Bultel wrote:
> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -231,6 +231,9 @@
> >  /* Sunplus UART */
> >  #define PORT_SUNPLUS	123
> >
> > +/* SH-SCI */
> > +#define PORT_RSCI	124
> 
> Why do you need to tell userspace about this specific port?  Is that a
> hard requirement that your userspace tools require?  If not, please don't
> export this here.

This point has been discussed with Geert and Wolfram.
We cannot use PORT_GENERIC for this IP, and adding the new type
is just keeping consistent with the sh-sci driver.

Thanks
Thierry

> 
> thanks,
> 
> greg k-h