linux-kernel - Re: [PATCH] genksyms: Handle typeof_unqual keyword and __seg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_y_0OXXn5v8Ngvr@gmail.com>
Date: Mon, 14 Apr 2025 09:57:04 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: linux-kernel@...r.kernel.org, Paul Menzel <pmenzel@...gen.mpg.de>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] genksyms: Handle typeof_unqual keyword and __seg_{fs,gs}
 qualifiers


* Uros Bizjak <ubizjak@...il.com> wrote:

> On Mon, Apr 14, 2025 at 9:20 AM Ingo Molnar <mingo@...nel.org> wrote:
> >
> >
> > * Uros Bizjak <ubizjak@...il.com> wrote:
> >
> > > Handle typeof_unqual, __typeof_unqual and __typeof_unqual__ keywords
> > > using TYPEOF_KEYW token in the same way as typeof keyword.
> > >
> > > Also ignore x86 __seg_fs and __seg_gs named address space qualifiers
> > > using X86_SEG_KEYW token in the same way as const, volatile or
> > > restrict qualifiers.
> > >
> > > Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> > > Reported-by: Paul Menzel <pmenzel@...gen.mpg.de>
> > > Closes: https://lore.kernel.org/lkml/81a25a60-de78-43fb-b56a-131151e1c035@molgen.mpg.de/
> > > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > > Cc: Ingo Molnar <mingo@...nel.org>
> > > Cc: Borislav Petkov <bp@...en8.de>
> > > ---
> > >  scripts/genksyms/keywords.c | 7 +++++++
> > >  scripts/genksyms/parse.y    | 5 ++++-
> > >  2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > Thanks, applied to tip:core/urgent.
> >
> > I've also added this tag for context:
> >
> >   Fixes: ac053946f5c4 ("compiler.h: introduce TYPEOF_UNQUAL() macro")
> 
> Heh, I intentionally removed it because the patch now fixes genksyms.

There's meritocratical value in generously accepting blame, even if you 
are only 10% to blame. ;-)

	Ingo