linux-kernel - Re: [PATCH v2 5/5] ALSA: korg1212: snd_korg1212_prepare: Rename del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70bb676764099754d10c4be2f095e0fb829f233a.camel@redhat.com>
Date: Mon, 14 Apr 2025 10:34:55 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: WangYuli <wangyuli@...ontech.com>
Cc: akpm@...ux-foundation.org, guanwentao@...ontech.com, 
 linux-kernel@...r.kernel.org, mingo@...nel.org, niecheng1@...ontech.com, 
 tglx@...utronix.de, zhanjun@...ontech.com, Jaroslav Kysela
 <perex@...ex.cz>,  Takashi Iwai <tiwai@...e.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>, SOUND <linux-sound@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] ALSA: korg1212: snd_korg1212_prepare: Rename
 del_timer in comment

On Mon, 2025-04-14 at 12:26 +0800, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to
> timer_delete[_sync]()")
> switched del_timer to timer_delete, but did not modify the comment
> for
> snd_korg1212_prepare(). Now fix it.
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Philipp Stanner <pstanner@...hat.com>
> Cc: SOUND <linux-sound@...r.kernel.org>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  sound/pci/korg1212/korg1212.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/korg1212/korg1212.c
> b/sound/pci/korg1212/korg1212.c
> index 49b71082c485..5e69bb25d420 100644
> --- a/sound/pci/korg1212/korg1212.c
> +++ b/sound/pci/korg1212/korg1212.c
> @@ -1553,7 +1553,7 @@ static int snd_korg1212_prepare(struct
> snd_pcm_substream *substream)
>  		return -EAGAIN;
>  		/*
>  		korg1212->sharedBufferPtr->cardCommand = 0;
> -		del_timer(&korg1212->timer);
> +		timer_delete(&korg1212->timer);
>  		korg1212->stop_pending_cnt = 0;
>  		*/

Wouldn't it be better to just remove all that? Or at least document
what it is good for?


P.


>  	}