linux-kernel - Re: [v2,1/1] i2c: designware: Add SMBus Quick Command support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_zKmx-60iWOjgs9@shikoro>
Date: Mon, 14 Apr 2025 10:43:07 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: ende.tan@...rfivetech.com, linux-i2c@...r.kernel.org,
	jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
	jsd@...ihalf.com, andi.shyti@...nel.org,
	linux-kernel@...r.kernel.org, leyfoon.tan@...rfivetech.com,
	endeneer@...il.com
Subject: Re: [v2,1/1] i2c: designware: Add SMBus Quick Command support


> > +	/* i2c-core-smbus.c: Only I2C_SMBUS_QUICK has msg[0].len = 0 */
> 
> Please, remove filenames from the code, better to refer to the actual functions
> as func(). This helps also to grep for all usages in case of renaming.

The comment can be removed. Regular I2C messages can also have a length
of 0.

> > +			     DW_IC_DEFAULT_FUNCTIONALITY;

Sidenote: Why do we have this define? It is used only once and makes
reading the actual functionalities harder, I'd say.

Also, I wonder if this patch really works in practice. The
I2C_AQ_NO_ZERO_LEN flag is still set, so the core should prevent such
messages to be passed on to the driver?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)