linux-kernel - Re: [PATCH] i2c: xgene-slimpro: Simplify PCC shared memory region handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250414-visionary-magnetic-ferret-ea0def@sudeepholla>
Date: Mon, 14 Apr 2025 09:58:21 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] i2c: xgene-slimpro: Simplify PCC shared memory region
 handling

On Mon, Apr 14, 2025 at 12:30:38AM +0200, Andi Shyti wrote:
> Hi Sudeep,
> 
> On Fri, Apr 11, 2025 at 12:23:03PM +0100, Sudeep Holla wrote:
> > The PCC driver now handles mapping and unmapping of shared memory
> > areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> > this xgene-slimpro I2C driver did handling of those mappings like several
> > other PCC mailbox client drivers.
> > 
> > There were redundant operations, leading to unnecessary code. Maintaining
> > the consistency across these driver was harder due to scattered handling
> > of shmem.
> > 
> > Just use the mapped shmem and remove all redundant operations from this
> > driver.
> > 
> > Cc: Andi Shyti <andi.shyti@...nel.org>
> > Cc: linux-i2c@...r.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> 
> I thought this patch was going to take other paths. Anyway, I
> merged it to i2c/i2c-host.
> 

Thanks, I too had assumed so, but the mailbox maintainer applied only PCC
mailbox changes only without any response in the thread. Sorry for that.

-- 
Regards,
Sudeep