linux-kernel - Re: [PATCH AUTOSEL 6.14 29/54] null_blk: replace null_process_cmd() call in null_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_xS4iiTNPJ5mP0-@lappy>
Date: Sun, 13 Apr 2025 20:12:18 -0400
From: Sasha Levin <sashal@...nel.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Damien Le Moal <dlemoal@...nel.org>,
	Johannes Thumshirn <Johannes.Thumshirn@....com>,
	Jens Axboe <axboe@...nel.dk>, "kch@...dia.com" <kch@...dia.com>,
	"yanjun.zhu@...ux.dev" <yanjun.zhu@...ux.dev>,
	"zhengqixing@...wei.com" <zhengqixing@...wei.com>,
	"yukuai3@...wei.com" <yukuai3@...wei.com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"hare@...e.de" <hare@...e.de>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 6.14 29/54] null_blk: replace null_process_cmd()
 call in null_zone_write()

On Fri, Apr 04, 2025 at 03:31:03AM +0000, Shinichiro Kawasaki wrote:
>On Apr 03, 2025 / 15:01, Sasha Levin wrote:
>> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>
>>
>> [ Upstream commit 4f235000b1e88934d1e6117dc43ed814710ef4e2 ]
>>
>> As a preparation to support partial data transfer due to badblocks,
>> replace the null_process_cmd() call in null_zone_write() with equivalent
>> calls to null_handle_badblocks() and null_handle_memory_backed(). This
>> commit does not change behavior. It will enable null_handle_badblocks()
>> to return the size of partial data transfer in the following commit,
>> allowing null_zone_write() to move write pointers appropriately.
>
>Hello Sasha, I don't think this patch should be in stable kernels, since it
>just refactors code as a preparation for another patch. I suggest to drop it
>for all stable kernels.

I'll drop it, thanks!

-- 
Thanks,
Sasha