linux-kernel - Re: arch/riscv/lib/strncmp.S:11: Error: unrecognized opcode `__alternative_cfg("nop", "j strncmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250414-5f143a94fdabfdef0191de46@orel>
Date: Mon, 14 Apr 2025 12:11:57 +0200
From: Andrew Jones <ajones@...tanamicro.com>
To: kernel test robot <lkp@...el.com>
Cc: Conor Dooley <conor.dooley@...rochip.com>, 
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	Alexandre Ghiti <alexghiti@...osinc.com>, Charlie Jenkins <charlie@...osinc.com>, 
	Samuel Holland <samuel.holland@...ive.com>
Subject: Re: arch/riscv/lib/strncmp.S:11: Error: unrecognized opcode
 `__alternative_cfg("nop", "j strncmp_zbb",0,30,'

On Sun, Apr 13, 2025 at 07:18:45AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   b676ac484f847bbe5c7d29603f41475b64fefe55
> commit: 9343aaba1f256ff42730db5a61efc32a86149776 RISC-V: separate Zbb optimisations requiring and not requiring toolchain support
> date:   4 weeks ago
> config: riscv-randconfig-001-20250413 (https://download.01.org/0day-ci/archive/20250413/202504130710.3IKz6Ibs-lkp@intel.com/config)
> compiler: riscv32-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250413/202504130710.3IKz6Ibs-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202504130710.3IKz6Ibs-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    arch/riscv/lib/strncmp.S: Assembler messages:
> >> arch/riscv/lib/strncmp.S:11: Error: unrecognized opcode `__alternative_cfg("nop", "j strncmp_zbb",0,30,'
> >> arch/riscv/lib/strncmp.S:12: Error: junk at end of line, first unrecognized character is `0'
> --
>    arch/riscv/lib/strlen.S: Assembler messages:
> >> arch/riscv/lib/strlen.S:11: Error: unrecognized opcode `__alternative_cfg("nop", "j strlen_zbb",0,30,'
> >> arch/riscv/lib/strlen.S:12: Error: junk at end of line, first unrecognized character is `0'
> --
>    arch/riscv/lib/strcmp.S: Assembler messages:
> >> arch/riscv/lib/strcmp.S:11: Error: unrecognized opcode `__alternative_cfg("nop", "j strcmp_zbb",0,30,'
> >> arch/riscv/lib/strcmp.S:12: Error: junk at end of line, first unrecognized character is `0'
>

We're missing __ALTERNATIVE_CFG() for !RISCV_ALTERNATIVE && __ASSEMBLY__
and I see some other missing/broken macros on the !RISCV_ALTERNATIVE side.
I'll send a patch.

Thanks,
drew