linux-kernel - Re: [PATCH v4 5/7] firmware: imx: Add i.MX95 SCMI LMM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250414-tiny-classic-barnacle-5f8c8f@sudeepholla>
Date: Mon, 14 Apr 2025 11:15:17 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Peng Fan <peng.fan@....com>
Cc: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
	Cristian Marussi <cristian.marussi@....com>,
	Sudeep Holla <sudeep.holla@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	"Pengutronix Kernel Team" <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, "Rob Herring" <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	"Conor Dooley" <conor+dt@...nel.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm-scmi@...r.kernel.org" <arm-scmi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 5/7] firmware: imx: Add i.MX95 SCMI LMM driver

On Mon, Apr 14, 2025 at 09:57:43AM +0000, Peng Fan wrote:
> Hi Sudeep,
> 
> > Subject: Re: [PATCH v4 5/7] firmware: imx: Add i.MX95 SCMI LMM
> > driver
> > 
> > On Tue, Apr 08, 2025 at 04:44:29PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > The i.MX95 System manager exports SCMI LMM protocol for linux to
> > > manage Logical Machines. The driver is to use the LMM Protocol
> > > interface to boot, shutdown a LM.
> > >
> > > Reviewed-by: Cristian Marussi <cristian.marussi@....com>
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >  drivers/firmware/arm_scmi/vendors/imx/Kconfig |  3 +-
> > >  drivers/firmware/imx/Kconfig                  | 11 ++++
> > >  drivers/firmware/imx/Makefile                 |  1 +
> > >  drivers/firmware/imx/sm-lmm.c                 | 91
> > +++++++++++++++++++++++++++
> > >  include/linux/firmware/imx/sm.h               | 14 +++++
> > >  5 files changed, 119 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/Kconfig
> > > b/drivers/firmware/arm_scmi/vendors/imx/Kconfig
> > > index
> > >
> > b5f13d0e40155e485f4d1696e9550645d888ef44..4c24e17425f83081
> > 0f8ba376ece9
> > > db93c8cded6d 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/Kconfig
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/Kconfig
> > > @@ -26,7 +26,8 @@ config IMX_SCMI_CPU_EXT  config
> > IMX_SCMI_LMM_EXT
> > >  	tristate "i.MX SCMI LMM EXTENSION"
> > >  	depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
> > > -	default y if ARCH_MXC
> > > +	depends on IMX_SCMI_LMM_DRV
> > > +	default y if ARCH_MXC && ARM64
> > 
> > I can't understand the ARM64 dependency on this and next patch.
> 
> ARCH_MXC both supports ARM32 and ARM64.
> 
> To i.MX ARM32 platform, there is no plan to enable SCMI, so only
> set y for ARCH_MXC ARM64 platforms.
> 

OK but why is it different for IMX_SCMI_MISC_DRV. I really don't see
any dependency. If it is not supported today fine, but do you need any
issue to use it or compile it for arm32 ?

-- 
Regards,
Sudeep