linux-kernel - Re: [PATCH 06/13] arm64: dts: freescale: imx93-phyboard-segin: Drop eMMC no-1-8-v flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f49d9b14-cba9-4ded-a10d-ec6372ec66f8@gmx.net>
Date: Mon, 14 Apr 2025 13:31:24 +0200
From: Stefan Wahren <wahrenst@....net>
To: Primoz Fiser <primoz.fiser@...ik.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>
Cc: devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 upstream@...ts.phytec.de
Subject: Re: [PATCH 06/13] arm64: dts: freescale: imx93-phyboard-segin: Drop
 eMMC no-1-8-v flag

Hi Primoz,

Am 14.04.25 um 12:39 schrieb Primoz Fiser:
> Hi Stefan,
>
> On 12. 04. 25 18:23, Stefan Wahren wrote:
>> Hi Primoz,
>>
>> Am 10.04.25 um 11:02 schrieb Primoz Fiser:
>>> Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set
>>> by default in the SOM include file (imx93-phycore-som.dtsi).
>>>
>>> Signed-off-by: Primoz Fiser <primoz.fiser@...ik.com>
>> i think, Patch 5 and this one should be squashed together.
> I intentionally split these series into SoM and board related patches.
>
> I see no benefit in squashing #5 and #6.
 From my understanding both changes belong together, because you 
actually moved the property from board to SoM level. Otherwise in case 
there is something wrong later, both patches need to be reverted.
> Also, I already got Frank's Reviewed-by tag on this patch.
This wouldn't invalidate Frank's review.

Just my two cents