linux-kernel - Re: [PATCH v8 10/13] arm64: dts: Add overlay for RP1 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abb3405a-45fb-4425-a817-89a03b0c16c4@gmx.net>
Date: Mon, 14 Apr 2025 13:38:29 +0200
From: Stefan Wahren <wahrenst@....net>
To: Andrea della Porta <andrea.porta@...e.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczynski <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Linus Walleij
 <linus.walleij@...aro.org>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
 <dragan.cvetic@....com>, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Saravana Kannan <saravanak@...gle.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-gpio@...r.kernel.org, Masahiro Yamada <masahiroy@...nel.org>,
 Herve Codina <herve.codina@...tlin.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Andrew Lunn
 <andrew@...n.ch>, Phil Elwell <phil@...pberrypi.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>, kernel-list@...pberrypi.com
Subject: Re: [PATCH v8 10/13] arm64: dts: Add overlay for RP1 device

Hi Andrea,

just a nit. Could you please add "broadcom:" to the subject?

Am 19.03.25 um 22:52 schrieb Andrea della Porta:
> Define the RP1 node in an overlay. The inclusion tree is
> as follow (the arrow points to the includer):
>
>                        rp1.dtso
>                            ^
>                            |
> rp1-common.dtsi ----> rp1-nexus.dtsi
>
> Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
> ---
> This patch can be considered optional, since it fills just the second
> scenario as detailed in [1], which is the RP1 DT node loaded from a dtb
> overlay by the FW at early boot stage.
> This may be useful for debug purpose, but as such not strictly necessary.
>
> [1] https://lore.kernel.org/all/CAMEGJJ0f4YUgdWBhxvQ_dquZHztve9KO7pvQjoDWJ3=zd3cgcg@mail.gmail.com/#t
> ---
>   arch/arm64/boot/dts/broadcom/Makefile |  3 ++-
>   arch/arm64/boot/dts/broadcom/rp1.dtso | 11 +++++++++++
>   2 files changed, 13 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm64/boot/dts/broadcom/rp1.dtso
>
> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile
> index 4836c6da5bee..58293f9c16ab 100644
> --- a/arch/arm64/boot/dts/broadcom/Makefile
> +++ b/arch/arm64/boot/dts/broadcom/Makefile
> @@ -13,7 +13,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \
>   			      bcm2837-rpi-3-b.dtb \
>   			      bcm2837-rpi-3-b-plus.dtb \
>   			      bcm2837-rpi-cm3-io3.dtb \
> -			      bcm2837-rpi-zero-2-w.dtb
> +			      bcm2837-rpi-zero-2-w.dtb \
> +			      rp1.dtbo
>   
>   subdir-y	+= bcmbca
>   subdir-y	+= northstar2
> diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso
> new file mode 100644
> index 000000000000..ab4f146d22c0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&pcie2 {
> +	#address-cells = <3>;
> +	#size-cells = <2>;
> +
> +	#include "rp1-nexus.dtsi"
> +};