[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb24afca-61c9-4c37-b98d-b2316ed79f98@kernel.org>
Date: Mon, 14 Apr 2025 14:03:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Darren Ye (叶飞) <Darren.Ye@...iatek.com>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"broonie@...nel.org" <broonie@...nel.org>, "brgl@...ev.pl" <brgl@...ev.pl>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "tiwai@...e.com"
<tiwai@...e.com>, "robh@...nel.org" <robh@...nel.org>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "perex@...ex.cz"
<perex@...ex.cz>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 11/11] ASoC: dt-bindings: mediatek,mt8196-mt6681: add
mt8196-mt6681 document
On 14/04/2025 09:08, Darren Ye (叶飞) wrote:
> On Mon, 2025-04-07 at 15:12 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 07/04/2025 14:06, Darren.Ye wrote:
>>> +
>>> +allOf:
>>> + - $ref: sound-card-common.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>
>> Drop
>
> Drop oneOf ?
Yes
>>> +
>>> +examples:
>>> + - |
>>> + sound {
>>> + compatible = "mediatek,mt8196-mt6681-sound";
>>> + model = "mt8196-mt6681";
>>> + mediatek,platform = <&afe>;
>>
>> Make the example complete.
> mt8196 pinctrl in mt8196-afe, does it have to be set in the machine
> driver?
I don't understand what do you ask me. Machine driver is not relevant to
this and I did not mention it. You have in the binding few properties
which are not present in DTS example. Why?
Best regards,
Krzysztof
Powered by blists - more mailing lists