linux-kernel - Re: [PATCH RFC net 1/2] net: bridge: switchdev: do not notify new brentries as changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250414125854.gtong53wmctv5pda@skbuf>
Date: Mon, 14 Apr 2025 15:58:54 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Nikolay Aleksandrov <razor@...ckwall.org>,
	Ido Schimmel <idosch@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>,
	bridge@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC net 1/2] net: bridge: switchdev: do not notify new
 brentries as changed

On Mon, Apr 14, 2025 at 02:11:18PM +0200, Jonas Gorski wrote:
> On Mon, Apr 14, 2025 at 1:39â€¯PM Vladimir Oltean <vladimir.oltean@....com> wrote:
> > > $ ip link add swbridge type bridge vlan_filtering 1 vlan_default_pvid 1
> 
> as mentioned for the cover letter, I will fix the example to use
> default_pvid 0 to have a "working" example.

Please do so. You have consistently given examples with vlan_default_pvid 1
throughout the patch set.

> Will add it. And I did check that, even considered shortly to merge this to
> 
>         if (becomes_brentry || would_change)
>                 *changed = true;
> 
> but then considered that a refactoring too much.

I agree that it would be an unnecessary change for 'net'. You can send a
refactoring patch for net-next after Thursday, though.