linux-kernel - Re: [PATCH v2 1/2] fs/fs_parse: Delete macro fsparam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <iefk2k2sa4sf5xz3jmmtaxmul4q63cje7kotieyqddlqp6rodg@coasknffadh2>
Date: Mon, 14 Apr 2025 15:17:04 +0200
From: Jan Kara <jack@...e.cz>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, David Howells <dhowells@...hat.com>, 
	Jonathan Corbet <corbet@....net>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2 1/2] fs/fs_parse: Delete macro fsparam_u32hex()

On Fri 11-04-25 23:31:40, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> Delete macro fsparam_u32hex() since:
> 
> - it has no caller.
> 
> - it uses as type @fs_param_is_u32_hex which is never defined, so will
>   cause compile error when caller uses it.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  Documentation/filesystems/mount_api.rst | 1 -
>  include/linux/fs_parser.h               | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/Documentation/filesystems/mount_api.rst b/Documentation/filesystems/mount_api.rst
> index d92c276f1575af11370dcd4a5d5d0ac97c4d7f4c..47dafbb7427e6a829989a815e4d034e48fdbe7a2 100644
> --- a/Documentation/filesystems/mount_api.rst
> +++ b/Documentation/filesystems/mount_api.rst
> @@ -671,7 +671,6 @@ The members are as follows:
>  	fsparam_bool()		fs_param_is_bool
>  	fsparam_u32()		fs_param_is_u32
>  	fsparam_u32oct()	fs_param_is_u32_octal
> -	fsparam_u32hex()	fs_param_is_u32_hex
>  	fsparam_s32()		fs_param_is_s32
>  	fsparam_u64()		fs_param_is_u64
>  	fsparam_enum()		fs_param_is_enum
> diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h
> index 53e566efd5fd133d19e313e494b975612a227b77..5057faf4f09182fa6e7ddd03fb17b066efd7e58b 100644
> --- a/include/linux/fs_parser.h
> +++ b/include/linux/fs_parser.h
> @@ -125,8 +125,6 @@ static inline bool fs_validate_description(const char *name,
>  #define fsparam_u32(NAME, OPT)	__fsparam(fs_param_is_u32, NAME, OPT, 0, NULL)
>  #define fsparam_u32oct(NAME, OPT) \
>  			__fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)8)
> -#define fsparam_u32hex(NAME, OPT) \
> -			__fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *)16)
>  #define fsparam_s32(NAME, OPT)	__fsparam(fs_param_is_s32, NAME, OPT, 0, NULL)
>  #define fsparam_u64(NAME, OPT)	__fsparam(fs_param_is_u64, NAME, OPT, 0, NULL)
>  #define fsparam_enum(NAME, OPT, array)	__fsparam(fs_param_is_enum, NAME, OPT, 0, array)
> 
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR