linux-kernel - Re: [PATCH] i2c: omap: fix deprecated of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3204f619-61a5-41b9-b9a5-c72397b21d11@quicinc.com>
Date: Tue, 15 Apr 2025 17:18:18 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Johan Hovold <johan+linaro@...nel.org>, Vignesh R <vigneshr@...com>,
        Andi
 Shyti <andi.shyti@...nel.org>
CC: Aaro Koskinen <aaro.koskinen@....fi>,
        Andreas Kemnade
	<andreas@...nade.info>,
        Kevin Hilman <khilman@...libre.com>,
        Roger Quadros
	<rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>,
        Janusz Krzysztofik
	<jmkrzyszt@...il.com>,
        <linux-omap@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Jayesh Choudhary
	<j-choudhary@...com>
Subject: Re: [PATCH] i2c: omap: fix deprecated of_property_read_bool() use



On 4/15/2025 1:22 PM, Johan Hovold wrote:
> Using of_property_read_bool() for non-boolean properties is deprecated
> and results in a warning during runtime since commit c141ecc3cecd ("of:
> Warn when of_property_read_bool() is used on non-boolean properties").
> 
> Fixes: b6ef830c60b6 ("i2c: omap: Add support for setting mux")
> Cc: Jayesh Choudhary <j-choudhary@...com>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>   drivers/i2c/busses/i2c-omap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 16afb9ca19bb..876791d20ed5 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1454,7 +1454,7 @@ omap_i2c_probe(struct platform_device *pdev)
>   				       (1000 * omap->speed / 8);
>   	}
>   
> -	if (of_property_read_bool(node, "mux-states")) {
> +	if (of_property_present(node, "mux-states")) {
>   		struct mux_state *mux_state;
>   
>   		mux_state = devm_mux_state_get(&pdev->dev, NULL);
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>