linux-kernel - Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <777983bf-08d2-4ccd-aa92-4791c8f9195d@web.de>
Date: Tue, 15 Apr 2025 13:55:05 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Kenneth Feng <kenneth.feng@....com>,
 Simona Vetter <simona@...ll.ch>, Xinhui Pan <Xinhui.Pan@....com>
Subject: Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error
 check in fiji_populate_smc_boot_level()

> The return value of fiji_populate_smc_boot_level() is needs to be checked.

                                                     should?


> An error handling is also needed to phm_find_boot_level() to reset the
> boot level when the function fails. A proper implementation can be found
> in tonga_populate_smc_boot_level().

Can you propose in a nicer way to complete the error handling?

Regards,
Markus