linux-kernel - Re: [PATCH next] pwm: loongson: Fix an error code in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bf96932-330c-483c-9a09-e84b73cd14ca@loongson.cn>
Date: Tue, 15 Apr 2025 20:16:20 +0800
From: Binbin Zhou <zhoubinbin@...ngson.cn>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Uwe Kleine-König <ukleinek@...nel.org>,
 Huacai Chen <chenhuacai@...nel.org>, Juxin Gao <gaojuxin@...ngson.cn>,
 linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] pwm: loongson: Fix an error code in probe()

Hi Dan:

Sorry for my late reply and thanks for fixing my cheap mistake.

On 2025/4/9 19:00, Dan Carpenter wrote:
> There is a copy and paste bug so we accidentally returned
> PTR_ERR(ddata->clk) instead of "ret".
>
> Fixes: 322fc380cea1 ("pwm: Add Loongson PWM controller support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
Reviewed-by: Binbin Zhou <zhoubinbin@...ngson.cn>
> ---
>   drivers/pwm/pwm-loongson.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-loongson.c b/drivers/pwm/pwm-loongson.c
> index 412c67739ef9..e31afb11ddd7 100644
> --- a/drivers/pwm/pwm-loongson.c
> +++ b/drivers/pwm/pwm-loongson.c
> @@ -211,7 +211,7 @@ static int pwm_loongson_probe(struct platform_device *pdev)
>   	if (ddata->clk) {
>   		ret = devm_clk_rate_exclusive_get(dev, ddata->clk);
>   		if (ret)
> -			return dev_err_probe(dev, PTR_ERR(ddata->clk),
> +			return dev_err_probe(dev, ret,
>   					     "Failed to get exclusive rate\n");
>   
>   		ddata->clk_rate = clk_get_rate(ddata->clk);
Thanks.
Binbin