lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025041510-virtual-flagstone-8b3f@gregkh>
Date: Tue, 15 Apr 2025 14:21:10 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Sudeep Holla <sudeep.holla@....com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/8] driver core: add helper macro for
 module_faux_driver() boilerplate

On Tue, Mar 18, 2025 at 05:01:39PM +0000, Sudeep Holla wrote:
> For simple modules that needs to create a faux device without any
> additional setup code ends up being a block of duplicated boilerplate.
> 
> Add a new macro, module_faux_driver(), which help to replaces the
> those duplicated boilerplate.
> 
> This macro use the same idea of module_platform_driver() but adds this
> initial condition to avoid creation of faux device if not necessary.

What is this "condition" for?

Every time you put "true" or "false" in the function call, someone will
have to look it up to see what is going on, that's going to be a pain.

Making apis is hard, let's not making using them even harder.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ