| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ceaf2591-5057-4ee4-99eb-42dacb0926c5@bootlin.com>
Date: Tue, 15 Apr 2025 14:27:39 +0200
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: hamohammed.sa@...il.com, simona@...ll.ch, melissa.srw@...il.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
airlied@...il.com, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 11/16] drm/vkms: Allow to attach connectors and
encoders via configfs
Le 07/04/2025 à 10:14, José Expósito a écrit :
> From: Louis Chauvet <louis.chauvet@...tlin.com>
>
> Create a default subgroup at
> /config/vkms/connectors/connector/possible_encoders that will contain
> symbolic links to the possible encoders for the connector.
Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Co-developed-by: José Expósito <jose.exposito89@...il.com>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>
> ---
> Documentation/gpu/vkms.rst | 2 +
> drivers/gpu/drm/vkms/vkms_configfs.c | 62 ++++++++++++++++++++++++++++
> 2 files changed, 64 insertions(+)
>
> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst
> index 744e2355db23..74126d2e32e4 100644
> --- a/Documentation/gpu/vkms.rst
> +++ b/Documentation/gpu/vkms.rst
> @@ -112,6 +112,7 @@ To finish the configuration, link the different pipeline items::
>
> sudo ln -s /config/vkms/my-vkms/crtcs/crtc0 /config/vkms/my-vkms/planes/plane0/possible_crtcs
> sudo ln -s /config/vkms/my-vkms/crtcs/crtc0 /config/vkms/my-vkms/encoders/encoder0/possible_crtcs
> + sudo ln -s /config/vkms/my-vkms/encoders/encoder0 /config/vkms/my-vkms/connectors/connector0/possible_encoders
>
> Since at least one primary plane is required, make sure to set the right type::
>
> @@ -129,6 +130,7 @@ And removing the top level directory and its subdirectories::
>
> sudo rm /config/vkms/my-vkms/planes/*/possible_crtcs/*
> sudo rm /config/vkms/my-vkms/encoders/*/possible_crtcs/*
> + sudo rm /config/vkms/my-vkms/connectors/*/possible_encoders/*
> sudo rmdir /config/vkms/my-vkms/planes/*
> sudo rmdir /config/vkms/my-vkms/crtcs/*
> sudo rmdir /config/vkms/my-vkms/encoders/*
> diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c
> index 692e1b708012..8e90acbebd6a 100644
> --- a/drivers/gpu/drm/vkms/vkms_configfs.c
> +++ b/drivers/gpu/drm/vkms/vkms_configfs.c
> @@ -88,11 +88,14 @@ struct vkms_configfs_encoder {
> *
> * @group: Top level configuration group that represents a connector.
> * Initialized when a new directory is created under "/config/vkms/connectors"
> + * @possible_encoders_group: Default subgroup of @group at
> + * "connector/possible_encoders"
> * @dev: The vkms_configfs_device this connector belongs to
> * @config: Configuration of the VKMS connector
> */
> struct vkms_configfs_connector {
> struct config_group group;
> + struct config_group possible_encoders_group;
> struct vkms_configfs_device *dev;
> struct vkms_config_connector *config;
> };
> @@ -126,6 +129,10 @@ struct vkms_configfs_connector {
> container_of(to_config_group((item)), struct vkms_configfs_connector, \
> group)
>
> +#define connector_possible_encoders_item_to_vkms_configfs_connector(item) \
> + container_of(to_config_group((item)), struct vkms_configfs_connector, \
> + possible_encoders_group)
> +
> static ssize_t crtc_writeback_show(struct config_item *item, char *page)
> {
> struct vkms_configfs_crtc *crtc;
> @@ -528,6 +535,55 @@ static const struct config_item_type connector_item_type = {
> .ct_owner = THIS_MODULE,
> };
>
> +static int connector_possible_encoders_allow_link(struct config_item *src,
> + struct config_item *target)
> +{
> + struct vkms_configfs_connector *connector;
> + struct vkms_configfs_encoder *encoder;
> + int ret;
> +
> + if (target->ci_type != &encoder_item_type)
> + return -EINVAL;
> +
> + connector = connector_possible_encoders_item_to_vkms_configfs_connector(src);
> + encoder = encoder_item_to_vkms_configfs_encoder(target);
> +
> + scoped_guard(mutex, &connector->dev->lock) {
> + if (connector->dev->enabled)
> + return -EBUSY;
> +
> + ret = vkms_config_connector_attach_encoder(connector->config,
> + encoder->config);
> + }
> +
> + return ret;
> +}
> +
> +static void connector_possible_encoders_drop_link(struct config_item *src,
> + struct config_item *target)
> +{
> + struct vkms_configfs_connector *connector;
> + struct vkms_configfs_encoder *encoder;
> +
> + connector = connector_possible_encoders_item_to_vkms_configfs_connector(src);
> + encoder = encoder_item_to_vkms_configfs_encoder(target);
> +
> + scoped_guard(mutex, &connector->dev->lock) {
> + vkms_config_connector_detach_encoder(connector->config,
> + encoder->config);
> + }
> +}
> +
> +static struct configfs_item_operations connector_possible_encoders_item_operations = {
> + .allow_link = connector_possible_encoders_allow_link,
> + .drop_link = connector_possible_encoders_drop_link,
> +};
> +
> +static const struct config_item_type connector_possible_encoders_group_type = {
> + .ct_item_ops = &connector_possible_encoders_item_operations,
> + .ct_owner = THIS_MODULE,
> +};
> +
> static struct config_group *make_connector_group(struct config_group *group,
> const char *name)
> {
> @@ -554,6 +610,12 @@ static struct config_group *make_connector_group(struct config_group *group,
>
> config_group_init_type_name(&connector->group, name,
> &connector_item_type);
> +
> + config_group_init_type_name(&connector->possible_encoders_group,
> + "possible_encoders",
> + &connector_possible_encoders_group_type);
> + configfs_add_default_group(&connector->possible_encoders_group,
> + &connector->group);
> }
>
> return &connector->group;
--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists