linux-kernel - Re: [PATCH v4 3/5] rust: auxiliary: add auxiliary device / driver abstractions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_5U9baQ-6VE2VjJ@cassiopeiae>
Date: Tue, 15 Apr 2025 14:45:41 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: gregkh@...uxfoundation.org, rafael@...nel.org, david.m.ertman@...el.com,
	ira.weiny@...el.com, ojeda@...nel.org, alex.gaynor@...il.com,
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
	benno.lossin@...ton.me, a.hindborg@...nel.org, tmgross@...ch.edu,
	airlied@...il.com, acourbot@...dia.com, jhubbard@...dia.com,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v4 3/5] rust: auxiliary: add auxiliary device / driver
 abstractions

On Tue, Apr 15, 2025 at 12:08:24PM +0000, Alice Ryhl wrote:
> On Mon, Apr 14, 2025 at 03:18:06PM +0200, Danilo Krummrich wrote:
> > Implement the basic auxiliary abstractions required to implement a
> > driver matching an auxiliary device.
> > 
> > The design and implementation is analogous to PCI and platform and is
> > based on the generic device / driver abstractions.
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Danilo Krummrich <dakr@...nel.org>
> 
> Overall looks okay to me, but I do have some comments.

Thanks for reviewing; unless there are more comments, I'll address those when
applying the series.

> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>