linux-kernel - Re: [EXT] [PATCH] [v2] mmc: esdhc-imx: convert to modern PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3d544dbc-863d-4ac5-9839-aef3a36881d1@app.fastmail.com>
Date: Tue, 15 Apr 2025 14:57:21 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Luke Wang" <ziniu.wang_1@....com>, "Arnd Bergmann" <arnd@...nel.org>,
 "Haibo Chen" <haibo.chen@....com>, "Adrian Hunter" <adrian.hunter@...el.com>,
 "Ulf Hansson" <ulf.hansson@...aro.org>, "Shawn Guo" <shawnguo@...nel.org>,
 "Sascha Hauer" <s.hauer@...gutronix.de>
Cc: "Pengutronix Kernel Team" <kernel@...gutronix.de>,
 "Fabio Estevam" <festevam@...il.com>, "Josua Mayer" <josua@...id-run.com>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
 "NXP S32 Linux Team" <S32@....com>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH] [v2] mmc: esdhc-imx: convert to modern PM_OPS

On Tue, Apr 15, 2025, at 05:15, Luke Wang wrote:
> Hi Arnd,
>
> This patch has compilation issue because sdhci.c still uses #ifdef 
> CONFIG_PM. Do you plan to send a new patch to fix? If not, I can send a 
> patch to fix the compilation warning.

Can you see if the change below is sufficient? I see I have that
in my randconfig tree and I did not see any problems with my
v2 patch and that. I probably added that one originally because
of some other build failure but then never sent it.

Signed-off-by: Arnd Bergmann <arnd@...db.de>

diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index cd0e35a80542..4ee2695b0202 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -874,12 +874,10 @@ irqreturn_t sdhci_thread_irq(int irq, void *dev_id);
 void sdhci_adma_write_desc(struct sdhci_host *host, void **desc,
                           dma_addr_t addr, int len, unsigned int cmd);

-#ifdef CONFIG_PM
 int sdhci_suspend_host(struct sdhci_host *host);
 int sdhci_resume_host(struct sdhci_host *host);
 int sdhci_runtime_suspend_host(struct sdhci_host *host);
 int sdhci_runtime_resume_host(struct sdhci_host *host, int soft_reset);
-#endif

 void sdhci_cqe_enable(struct mmc_host *mmc);
 void sdhci_cqe_disable(struct mmc_host *mmc, bool recovery);