linux-kernel - Re: [PATCH 2/2] kunit: qemu_configs: Add PowerPC 32-bit BE and 64-bit LE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSm6TigevXXL7c5g9AmarzYpHtWvuRJd7ubp0K9bgpwVSQ@mail.gmail.com>
Date: Tue, 15 Apr 2025 21:11:16 +0800
From: David Gow <davidgow@...gle.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Rae Moar <rmoar@...gle.com>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] kunit: qemu_configs: Add PowerPC 32-bit BE and 64-bit LE

On Tue, 15 Apr 2025 at 17:23, Thomas Weißschuh
<thomas.weissschuh@...utronix.de> wrote:
>
> Add basic configs to run kunit tests on some more PowerPC variants.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---

Hmm... a part of me wonders whether it'd make more sense to rename the
64-bit one to powerpc64, to match e.g. arm/arm64. But it's probably
not worth the breakage for existing users.
Equally, I doubt there are enough people who care about 32-bit little
endian to warrant a powerpc32le config (and if there are, they can
always add them in a follow up).

So this looks good as-is, thanks!

Reviewed-by: David Gow <davidgow@...gle.com>


>  tools/testing/kunit/qemu_configs/powerpc32.py | 17 +++++++++++++++++
>  tools/testing/kunit/qemu_configs/powerpcle.py | 14 ++++++++++++++
>  2 files changed, 31 insertions(+)
>
> diff --git a/tools/testing/kunit/qemu_configs/powerpc32.py b/tools/testing/kunit/qemu_configs/powerpc32.py
> new file mode 100644
> index 0000000000000000000000000000000000000000..88bd60dbb9483af244d42d3d36c769ce2effe2b4
> --- /dev/null
> +++ b/tools/testing/kunit/qemu_configs/powerpc32.py
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +from ..qemu_config import QemuArchParams
> +
> +QEMU_ARCH = QemuArchParams(linux_arch='powerpc',
> +                          kconfig='''
> +CONFIG_PPC32=y
> +CONFIG_CPU_BIG_ENDIAN=y
> +CONFIG_ADB_CUDA=y
> +CONFIG_SERIAL_PMACZILOG=y
> +CONFIG_SERIAL_PMACZILOG_TTYS=y
> +CONFIG_SERIAL_PMACZILOG_CONSOLE=y
> +''',
> +                          qemu_arch='ppc',
> +                          kernel_path='vmlinux',
> +                          kernel_command_line='console=ttyS0',
> +                          extra_qemu_params=['-M', 'g3beige', '-cpu', 'max'])
> diff --git a/tools/testing/kunit/qemu_configs/powerpcle.py b/tools/testing/kunit/qemu_configs/powerpcle.py
> new file mode 100644
> index 0000000000000000000000000000000000000000..7ddee8af4bd79a85a1dbbbd0446d3ea47c5947d8
> --- /dev/null
> +++ b/tools/testing/kunit/qemu_configs/powerpcle.py
> @@ -0,0 +1,14 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +from ..qemu_config import QemuArchParams
> +
> +QEMU_ARCH = QemuArchParams(linux_arch='powerpc',
> +                          kconfig='''
> +CONFIG_PPC64=y
> +CONFIG_CPU_LITTLE_ENDIAN=y
> +CONFIG_HVC_CONSOLE=y
> +''',
> +                          qemu_arch='ppc64',
> +                          kernel_path='vmlinux',
> +                          kernel_command_line='console=ttyS0',
> +                          extra_qemu_params=['-M', 'pseries', '-cpu', 'power8'])
>
> --
> 2.49.0
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)