linux-kernel - Re: [PATCH net] net: phy: microchip: force IRQ polling mode for lan88xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0c0af22-6825-48de-8485-ef294c840f6d@lunn.ch>
Date: Tue, 15 Apr 2025 15:24:52 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Fiona Klute <fiona.klute@....de>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	Thangaraj Samynathan <Thangaraj.S@...rochip.com>,
	Rengarajan Sundararajan <Rengarajan.S@...rochip.com>,
	UNGLinuxDriver@...rochip.com,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-list@...pberrypi.com
Subject: Re: [PATCH net] net: phy: microchip: force IRQ polling mode for
 lan88xx

> > Thanks for submitting this. Two nit picks:
> > 
> > It needed a Fixes: tag. Probably:
> > 
> > Fixes: 792aec47d59d ("add microchip LAN88xx phy driver")
> Sure, will add that (and a comment) and resend. I wasn't sure if I
> should add it if I can't pinpoint exactly where the problem was
> introduced, and it looks like the interrupt handling was changed a bit
> after.

If you can prove interrupt handling did actually work to start with,
maybe a later commit could be referenced. But i'm not sure it is worth
the effort.

	Andrew