linux-kernel - Re: [PATCH next] drm/amdkfd: Fix kfd_smi_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e066edc-e279-4252-ba67-b4be2b462084@amd.com>
Date: Tue, 15 Apr 2025 09:35:27 -0400
From: Eric Huang <jinhuieric.huang@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Felix Kuehling <Felix.Kuehling@....com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Kent Russell <kent.russell@....com>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/amdkfd: Fix kfd_smi_event_process()

Thanks for the fix, I had the same patch submitted yesterday.

Regards,
Eric

On 2025-04-15 06:44, Dan Carpenter wrote:
> The "pdd->drm_priv" NULL check is reversed so it will lead to a NULL
> dereference on the next line.
>
> Fixes: 4172b556fd5b ("drm/amdkfd: add smi events for process start and end")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index 727a4ce29fe6..c27fd7aec1c3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -350,7 +350,7 @@ void kfd_smi_event_process(struct kfd_process_device *pdd, bool start)
>   	struct amdgpu_task_info *task_info;
>   	struct amdgpu_vm *avm;
>   
> -	if (pdd->drm_priv)
> +	if (!pdd->drm_priv)
>   		return;
>   
>   	avm = drm_priv_to_vm(pdd->drm_priv);