linux-kernel - Re: [PATCH v4 2/2] rcutorture: Fix issue with re-using old images on ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d549c29-1036-457f-a909-65c9dcc08a62@nvidia.com>
Date: Tue, 15 Apr 2025 09:46:24 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: linux-kernel@...r.kernel.org, Davidlohr Bueso <dave@...olabs.net>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 Josh Triplett <josh@...htriplett.org>,
 Frederic Weisbecker <frederic@...nel.org>,
 Neeraj Upadhyay <neeraj.upadhyay@...nel.org>,
 Joel Fernandes <joel@...lfernandes.org>, Boqun Feng <boqun.feng@...il.com>,
 Uladzislau Rezki <urezki@...il.com>, Steven Rostedt <rostedt@...dmis.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Lai Jiangshan <jiangshanlai@...il.com>, Zqiang <qiang.zhang1211@...il.com>,
 Shuah Khan <shuah@...nel.org>
Cc: rcu@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v4 2/2] rcutorture: Fix issue with re-using old images on
 ARM64

On 4/15/2025 9:36 AM, Joel Fernandes wrote:
> On ARM64, when running with --configs '36*SRCU-P', I noticed that only 1 instance
> instead of 36 for starting.
> 
> Fix it by checking for Image files, instead of bzImage which ARM does
> not seem to have. With this I see all 36 instances running at the same
> time in the batch.
> 
> Tested-by: Paul E. McKenney <paulmck@...nel.org>
> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
> ---
>  kernel/rcu/rcutorture.c                                  | 3 ++-
>  tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 74de92c3a9ab..df6504a855aa 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -2412,7 +2412,8 @@ rcu_torture_stats_print(void)
>  			pipesummary[i] += READ_ONCE(per_cpu(rcu_torture_count, cpu)[i]);
>  			batchsummary[i] += READ_ONCE(per_cpu(rcu_torture_batch, cpu)[i]);
>  		}
> -		n_gpwraps += cur_ops->get_gpwrap_count(cpu);
> +		if (cur_ops->get_gpwrap_count)
> +			n_gpwraps += cur_ops->get_gpwrap_count(cpu);
>  	}
Oops, this hunk was supposed to go into the previous patch. I fixed it in my
tree and will post with the full set of torture patches later:

https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/log/?h=rcu/torture-for-6.16

Thanks.