linux-kernel - Re: [1/2] ASoC: codecs: wcd938x: fix mux error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5af56acb-7758-4641-8acc-b81e7c8de709@web.de>
Date: Tue, 15 Apr 2025 15:57:03 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Johan Hovold <johan@...nel.org>, linux-sound@...r.kernel.org
Cc: Johan Hovold <johan+linaro@...nel.org>,
 LKML <linux-kernel@...r.kernel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Mark Brown <broonie@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Peter Rosin <peda@...ntia.se>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Takashi Iwai <tiwai@...e.com>
Subject: Re: [1/2] ASoC: codecs: wcd938x: fix mux error handling

>> May the error code assignment statement be omitted here together with extra curly brackets
>> (as such a case is demonstrated in a subsequent if branch)?
> 
> I considered that, but I prefer using a temporary variable as it is more readable.
Would your coding style preferences be inconsistent here?

Regards,
Markus