linux-kernel - Re: [PATCH v2 net] net: ngbe: fix memory leak in ngbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174472683377.2655627.17227105626951584130.git-patchwork-notify@kernel.org>
Date: Tue, 15 Apr 2025 14:20:33 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Abdun Nihaal <abdun.nihaal@...il.com>
Cc: jiawenwu@...stnetic.com, Markus.Elfring@....de, mengyuanlou@...-swift.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, saikrishnag@...vell.com,
 przemyslaw.kitszel@...el.com, ecree.xilinx@...il.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net: ngbe: fix memory leak in ngbe_probe() error path

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Sat, 12 Apr 2025 21:19:24 +0530 you wrote:
> When ngbe_sw_init() is called, memory is allocated for wx->rss_key
> in wx_init_rss_key(). However, in ngbe_probe() function, the subsequent
> error paths after ngbe_sw_init() don't free the rss_key. Fix that by
> freeing it in error path along with wx->mac_table.
> 
> Also change the label to which execution jumps when ngbe_sw_init()
> fails, because otherwise, it could lead to a double free for rss_key,
> when the mac_table allocation fails in wx_sw_init().
> 
> [...]

Here is the summary with links:
  - [v2,net] net: ngbe: fix memory leak in ngbe_probe() error path
    https://git.kernel.org/netdev/net/c/88fa80021b77

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html