linux-kernel - RE: [PATCH 3/7] ASoC: codec: twl4030: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB84595DCC6615FFDAC1FD84DF88B22@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Tue, 15 Apr 2025 14:41:32 +0000
From: Peng Fan <peng.fan@....com>
To: Linus Walleij <linus.walleij@...aro.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>, Baojun
 Xu <baojun.xu@...com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, Peter Ujfalusi
	<peter.ujfalusi@...il.com>, David Rhodes <david.rhodes@...rus.com>, Richard
 Fitzgerald <rf@...nsource.cirrus.com>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "patches@...nsource.cirrus.com"
	<patches@...nsource.cirrus.com>, Tony Lindgren <tony@...mide.com>
Subject: RE: [PATCH 3/7] ASoC: codec: twl4030: Convert to GPIO descriptors

Hi Linus,

> Subject: Re: [PATCH 3/7] ASoC: codec: twl4030: Convert to GPIO
> descriptors
> 
> On Tue, Apr 8, 2025 at 3:41 AM Peng Fan (OSS)
> <peng.fan@....nxp.com> wrote:
> 
> > From: Peng Fan <peng.fan@....com>
> >
> > of_gpio.h is deprecated, update the driver to use GPIO descriptors.
> >  - Use of_property_present to check "ti,hs_extmute_gpio" to set
> > hs_extmute
> >  - if returned value is true.
> >  - Use devm_gpiod_get_optional to get GPIO descriptor, set
> consumer name.
> >  - Use gpiod_set_value to configure output value.
> >
> > While at here
> >  - reorder the included headers.
> >  - drop remove hook after switching to use devm_gpiod_get_optional
> >  - Add return value for twl4030_init_chip to propagate value to
> parent
> >    in case defer probe happens
> >
> > Checking the only user logicpd-som-lv.dtsi that uses polarity
> > GPIO_ACTIVE_HIGH, so all should work as expected.
> >
> > Cc: Tony Lindgren <tony@...mide.com>
> > Signed-off-by: Peng Fan <peng.fan@....com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for reviewing.

Mark raised a comment that he would like to see
Separate the changes(e.g below) to a driver into
separate patches.
-Reorder headers
-Cleanup drivers
-Convert to GPIOD descriptors

So I would redo the patches, and please not
waste reviewing efforts on this version.

Thanks,
Peng.

> 
> Yours,
> Linus Walleij