linux-kernel - Re: [PATCH] of: reserved-mem: Warn for missing initfn in __reservedmem_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq++MbY=s5t1hmE0AhcmFA14t3fxLM1xPFZAA0ETX_ee-g@mail.gmail.com>
Date: Tue, 15 Apr 2025 09:51:59 -0500
From: Rob Herring <robh@...nel.org>
To: Liya Huang <1425075683@...com>
Cc: Saravana Kannan <saravanak@...gle.com>, Marek Szyprowski <m.szyprowski@...sung.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: reserved-mem: Warn for missing initfn in __reservedmem_of_table

On Tue, Apr 15, 2025 at 9:16 AM Liya Huang <1425075683@...com> wrote:
>
> For the data in __reservedmem_of_table, its function pointer initfn might
> be NULL. However, __reserved_mem_init_node() only considers non-NULL cases
> and ignores NULL function pointers.

If initfn is NULL, there's no point to the entry and that's a bug.
Unless you have a build time check, there's no point to add this.

Rob