linux-kernel - Re: [PATCH v3] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025041537-refusal-suspense-3e7b@gregkh>
Date: Tue, 15 Apr 2025 16:57:45 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Christian Schrefl <chrisi.schrefl@...il.com>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Russ Weight <russ.weight@...ux.dev>,
	Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v3] rust: Use `ffi::c_char` type in firmware abstraction
 `FwFunc`

On Sun, Apr 13, 2025 at 10:21:01PM +0200, Miguel Ojeda wrote:
> On Sun, Apr 13, 2025 at 9:27 PM Christian Schrefl
> <chrisi.schrefl@...il.com> wrote:
> >
> > The `FwFunc` struct contains an function with a char pointer argument,
> > for which a `*const u8` pointer was used. This is not really the
> > "proper" type for this, so use a `*const kernel::ffi::c_char` pointer
> > instead.
> 
> If I don't take it:
> 
> Acked-by: Miguel Ojeda <ojeda@...nel.org>

Thanks, I'll take it now.

greg k-h