linux-kernel - Re: [PATCH v2 5/5] ALSA: korg1212: snd_korg1212_prepare: Rename del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmblxwbt.wl-tiwai@suse.de>
Date: Tue, 15 Apr 2025 17:45:26 +0200
From: Takashi Iwai <tiwai@...e.de>
To: WangYuli <wangyuli@...ontech.com>
Cc: Philipp Stanner <pstanner@...hat.com>,
	akpm@...ux-foundation.org,
	guanwentao@...ontech.com,
	linux-kernel@...r.kernel.org,
	mingo@...nel.org,
	niecheng1@...ontech.com,
	tglx@...utronix.de,
	zhanjun@...ontech.com,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	SOUND <linux-sound@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] ALSA: korg1212: snd_korg1212_prepare: Rename del_timer in comment

On Mon, 14 Apr 2025 13:10:39 +0200,
WangYuli wrote:
> 
> Hi Philipp Stanner,
> 
> On 2025/4/14 16:34, Philipp Stanner wrote:
> > Wouldn't it be better to just remove all that? Or at least document
> > what it is good for?
> 
> This code comes from commit 4d6dcf60b9 ("ALSA update   - documentation
>   - control API - added multi-elements to reduce memory usage   -
> improved preallocation of DMA buffers   - CS46xx driver - added
> support for secondary codec   - HDSP driver - big update     -
> firmware is loaded with hdsptool now   - pmac driver updates (fixed
> oops and beep stuff)   - VIA82xx driver updated   - ymfpci driver
> updated   - drivers updated to new PnP layer     - wavefront, ad1816a,
> cs423x, es18xx, interwave, opl3sa2, cmi8330") in the history tree [1]
> as part of a huge patch.
> 
> I couldn't find any useful information about this specific code within
> that commit.
> 
> Since I'm uncertain if we truly don't need it (this code is marked
> with "FIXME" above), I've kept this comment.
> 
> Furthermore, this driver has other sections of commented-out code as
> well, so a more comprehensive cleanup of this driver might be a better
> approach in the future.
> 
> If possible, I'd also be happy to contribute to that effort.
> 
> However, this commit isn't intended for that purpose.
> 
> Its sole aim is to clean up the comment that were missed by commit
> 8fa7292fee5c ("treewide: Switch/rename to timer_delete_sync") and
> should have been updated.
> 
> 
> [1]. https://web.git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=4d6dcf60b98000c204b309b529c10b2a3884789e

Yeah, the code is quite old and dirty, and this timer stuff can be
omitted completely by introducing the proper sync_stop PCM ops.
Let me rewrite the code instead.


thanks,

Takashi