linux-kernel - Re: [PATCH v4 4/5] platform/x86/amd: pmc: use FCH_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8d3c4c0-4ca4-4576-b38a-727d1803ee77@kernel.org>
Date: Tue, 15 Apr 2025 10:45:48 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: Borislav Petkov <bp@...en8.de>, Jean Delvare <jdelvare@...e.com>,
 Andi Shyti <andi.shyti@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jonathan Corbet <corbet@....net>,
 Mario Limonciello <mario.limonciello@....com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H . Peter Anvin" <hpa@...or.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Hans de Goede <hdegoede@...hat.com>,
 "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" <linux-i2c@...r.kernel.org>,
 "open list:AMD PMC DRIVER" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v4 4/5] platform/x86/amd: pmc: use FCH_PM_BASE definition

On 4/15/2025 10:13 AM, Yazen Ghannam wrote:
> On Mon, Apr 14, 2025 at 07:26:57PM -0500, Mario Limonciello wrote:
>> From: Mario Limonciello <mario.limonciello@....com>
>>
>> The s2idle mmio quirk uses a scratch register in the FCH.
>> Adjust the code to clarify that.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>> ---
>> v4:
>>   * Use fch.h instead
>> ---
>>   arch/x86/include/asm/amd/fch.h            | 1 +
>>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 3 ++-
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/amd/fch.h b/arch/x86/include/asm/amd/fch.h
>> index a5fd91ff92df3..9b32e8a03193e 100644
>> --- a/arch/x86/include/asm/amd/fch.h
>> +++ b/arch/x86/include/asm/amd/fch.h
>> @@ -8,5 +8,6 @@
>>   /* register offsets from PM base */
>>   #define FCH_PM_DECODEEN			0x00
>>   #define FCH_PM_DECODEEN_SMBUS0SEL	GENMASK(20, 19)
>> +#define FCH_PM_SCRATCH			0x80
>>   
>>   #endif
>> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> index b4f49720c87f6..3c680d2029f62 100644
>> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> @@ -8,6 +8,7 @@
>>    * Author: Mario Limonciello <mario.limonciello@....com>
>>    */
>>   
>> +#include <asm/amd/fch.h>
> 
> Arch headers should go after linux headers, I think.
> 
> So that arch stuff can override generic stuff.
> 

Thanks - that's the same problem for the previous patch (i2c: piix4: 
Move SB800_PIIX4_FCH_PM_ADDR definition to amd/fch.) too then.

I'll fix it in the next spin.

>>   #include <linux/dmi.h>
>>   #include <linux/io.h>
>>   #include <linux/ioport.h>
> 
> Thanks,
> Yazen